From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: mfd: lm3533: Set DMA mask Date: Thu, 04 Jun 2026 13:59:55 +1000 Message-ID: In-Reply-To: <20260601151831.76350-8-clamor95@gmail.com> References: <20260601151831.76350-1-clamor95@gmail.com> <20260601151831.76350-8-clamor95@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review ```c i2c->dev.coherent_dma_mask = 0; i2c->dev.dma_mask = &i2c->dev.coherent_dma_mask; ``` This approach is questionable. The warning "DMA mask not set" comes from the child MFD platform devices, not the i2c parent. Setting the DMA mask on the i2c device may not propagate correctly to MFD children created by `mfd_add_devices()`. The proper fix is likely in the MFD core or by using `dma_coerce_mask_and_coherent()` on the child devices. I'd suggest confirming this actually silences the warning. --- Generated by Claude Code Patch Reviewer