From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/v3d: Migrate BO reservation locking to DRM exec Date: Thu, 04 Jun 2026 11:24:41 +1000 Message-ID: In-Reply-To: <20260603-v3d-sched-misc-fixes-v3-7-d7114bba55a0@igalia.com> References: <20260603-v3d-sched-misc-fixes-v3-0-d7114bba55a0@igalia.com> <20260603-v3d-sched-misc-fixes-v3-7-d7114bba55a0@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Straightforward conversion from `drm_gem_(un)lock_reservations()` + `ww_acquire_ctx` to `drm_exec`. The `drm_exec_prepare_array()` call with `num_fences=1` replaces the manual `dma_resv_reserve_fences()` loop, which is a nice simplification. One note: in the error path of `v3d_submit_cpu_ioctl()`, both `drm_exec_fini(&exec)` and `drm_exec_fini(&cpu_job->indirect_csd.exec)` are called unconditionally. Calling `drm_exec_fini()` on a zero-initialized `struct drm_exec` is safe (it checks internal state), so this is fine. Reviewed-by: Tvrtko Ursulin. No issues. --- Generated by Claude Code Patch Reviewer