From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: rust: io: mem: return DevresLt from IoMem/ExclusiveIoMem::into_devres() Date: Thu, 04 Jun 2026 12:08:40 +1000 Message-ID: In-Reply-To: <20260603011020.2073650-8-dakr@kernel.org> References: <20260603011020.2073650-1-dakr@kernel.org> <20260603011020.2073650-8-dakr@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Same pattern as Patch 6, applied to `IoMem` and `ExclusiveIoMem`. The covar= iance safety arguments are correct =E2=80=94 both types ultimately hold `&'= a Device`. The `pwm_th1520.rs` update from `devres::Devres>` to `D= evresIoMem<...>` is a clean consumer-side improvement. The driver drops its= `devres` import and uses the more specific type alias: ```rust - iomem: devres::Devres>, + iomem: DevresIoMem, ``` No issues. --- **Summary:** Well-structured v2 series with sound safety arguments. The `Fo= rLt`/`CovariantForLt` split, HRTB closure pattern, and `DevresLt` abstracti= on are all correctly designed. No correctness bugs found. The minor observa= tions above are all non-blocking. --- Generated by Claude Code Patch Reviewer