From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panfrost: Explicitly enable MMU interrupts at device init Date: Fri, 05 Jun 2026 06:16:25 +1000 Message-ID: In-Reply-To: <20260604-claude-fixes-v2-7-57c6bd4c1655@collabora.com> References: <20260604-claude-fixes-v2-0-57c6bd4c1655@collabora.com> <20260604-claude-fixes-v2-7-57c6bd4c1655@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Verdict: Correct, follows naturally from patch 6.** ```c int panfrost_mmu_init(struct panfrost_device *pfdev) { ... panfrost_mmu_enable_interrupts(pfdev); return 0; } ``` Since patch 6 ensures the device starts active (with PM get/put around prob= e), there's a window between `drm_dev_register()` and when autosuspend trig= gers the first `runtime_suspend`/`runtime_resume` cycle. During this window= , jobs could be submitted but MMU interrupts weren't enabled (they're only = enabled in `panfrost_mmu_reset()`, called from `panfrost_device_reset()`, c= alled from `runtime_resume()`). This patch closes that gap. The refactoring of `mmu_write` calls into `panfrost_mmu_enable_interrupts()= ` is clean and used in both `panfrost_mmu_reset()` and `panfrost_mmu_init()= `. --- ## SUMMARY OF ISSUES 1. **Patch 5 =E2=80=94 Bug:** `ret =3D EAGAIN` must be `ret =3D -EAGAIN` (l= ine ~988 in the mbox) 2. **Patch 5 =E2=80=94 Bug:** `err_disable` error path leaks the AS referen= ce from `panfrost_mmu_as_get()` =E2=80=94 needs `panfrost_mmu_as_put()` bef= ore falling through to `err_vunmap` 3. **Patch 4 =E2=80=94 Note:** Register write ordering changed in `disable_= locked` (enable regs vs config reg) =E2=80=94 verify HW is order-agnostic 4. **Patch 5 =E2=80=94 Design:** `panfrost_perfcnt_reset()` writes GPU regi= sters without locking =E2=80=94 acceptable given the subsequent soft reset,= but should be explicitly noted --- Generated by Claude Code Patch Reviewer