From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbdev: au1100fb: Replace license boilerplate by SPDX header Date: Mon, 16 Feb 2026 11:57:00 +1000 Message-ID: In-Reply-To: =?utf-8?q?=3C378a47fdfe6d90d1dd1420b4c162a2b545e194ad=2E1771163?= =?utf-8?q?316=2Egit=2Eu=2Ekleine-koenig=40baylibre=2Ecom=3E?= References: =?utf-8?q??= =?utf-8?q?=3C378a47fdfe6d90d1dd1420b4c162a2b545e194ad=2E1771163316=2Egit=2E?= =?utf-8?q?u=2Ekleine-koenig=40baylibre=2Ecom=3E?= X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review No regressions found. The original "version 2 or later" GPL text correctly ma= ps to `GPL-2.0-or-later`. --- ## review-inline.txt content ``` Series: fbdev: au1100fb: support COMPILE_TEST and fix multi-device support and other cleanups Author: Uwe Kleine-Koenig This is a 7 patch cleanup series for the au1100fb fbdev driver, moving global data into per-device structures, adding COMPILE_TEST support, converting printk wrappers to pr_*, folding the header file into the .c file, and replacing the license boilerplate with SPDX. Two minor issues found. Patch 5/7 - fbdev: au1100fb: Replace custom printk wrappers by pr_* > diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100fb.c > index 782f70c3a98f..86aafa4f0966 100644 > --- a/drivers/video/fbdev/au1100fb.c > +++ b/drivers/video/fbdev/au1100fb.c [ ... ] > +#define pr_fmt(fmt) "au1100fb:" fmt "\n" The old print_err/print_warn/print_info macros used DRIVER_NAME ": " (with a space after the colon), e.g.: printk(KERN_ERR DRIVER_NAME ": " f "\n", ## arg) The new pr_fmt omits the space, so all messages change from "au1100fb: some message" to "au1100fb:some message". Should this be "au1100fb: " fmt "\n" to preserve the original formatting? Patch 6/7 - fbdev: au1100fb: Fold au1100fb.h into its only user > diff --git a/drivers/video/au1100fb.c b/drivers/video/au1100fb.c > new file mode 100644 > index 000000000000..e69de29bb2d1 This creates an empty file at drivers/video/au1100fb.c (note: not in the fbdev/ subdirectory). Was this file included by accident? ``` ## review-metadata.json content ```json { "author": "Uwe Kleine-Koenig ", "sha": "cover.1771163316.git.u.kleine-koenig@baylibre.com", "subject": "fbdev: au1100fb: support COMPILE_TEST and fix multi-device supp= ort and other cleanups", "AI-authorship-score": "low", "AI-authorship-explanation": "The series shows typical human patterns: incr= emental cleanup of a legacy driver, personal coding style, v4 iteration histo= ry with specific reviewer feedback addressed, and domain-specific MIPS hardwa= re knowledge.", "issues-found": 2, "issue-severity-score": "low", "issue-severity-explanation": "Missing space in pr_fmt prefix and an accide= ntally created empty file are cosmetic and cleanup issues with no functional = impact." } ``` --- FINAL REGRESSIONS FOUND: 2 False positives eliminated: - Considered whether the compound literal initialization ordering in Patch 1 = could cause uninitialized field access -- verified field assignment order is = equivalent to original - Considered whether `pr_devel` behavior changed with `#define DEBUG 0` remov= al -- verified `pr_devel` compiles out when DEBUG is not defined, matching ol= d behavior - Considered whether `#ifndef CONFIG_S390` in Patch 4 could cause issues on M= IPS -- verified CONFIG_S390 is never set on MIPS - Considered whether the `%pad` format specifier in Patch 3 adds a duplicate = `0x` prefix -- verified `%pad` prints hex digits without prefix ### Task 5: AI authorship estimate AI-authorship-score: low The series shows typical human authorship patterns: it addresses a real-world= problem (COMPILE_TEST support) for a legacy driver, includes incremental v1-= v4 iteration with specific version notes referencing reviewer feedback, uses = personal coding conventions, and demonstrates domain-specific knowledge of MI= PS memory mapping (KSEG1ADDR, CCA bits). ### Task 6: Issue severity issue-severity-score: low Both issues are cosmetic/cleanup: a missing space in log message prefix and a= n accidentally created empty file. Neither has any functional impact on the d= river's behavior. FINAL TOKENS USED: ~45000 --- Generated by Claude Code Patch Reviewer