From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: cdns-dsi: Use __drm_atomic_helper_bridge_state_init() Date: Thu, 04 Jun 2026 15:45:43 +1000 Message-ID: In-Reply-To: <20260530-drm-no-more-bridge-reset-v1-73-875d828d31bc@kernel.org> References: <20260530-drm-no-more-bridge-reset-v1-0-875d828d31bc@kernel.org> <20260530-drm-no-more-bridge-reset-v1-73-875d828d31bc@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Replaces open-coded state initialization: ```c - memset(dsi_state, 0, sizeof(*dsi_state)); - dsi_state->base.bridge = bridge; + __drm_atomic_helper_bridge_state_init(&dsi_state->base, bridge); ``` The `memset` was redundant (already kzalloc'd), and the manual `bridge` assignment is what the helper does. Good cleanup. Note this also means the cdns-dsi state now gets `__drm_atomic_helper_private_obj_create_state()` called, which it wasn't getting before. This links the state properly into the private object infrastructure -- a correctness improvement. No issues. --- Generated by Claude Code Patch Reviewer