From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: cdns-dsi: Switch to atomic_create_state
Date: Thu, 04 Jun 2026 15:45:43 +1000 [thread overview]
Message-ID: <review-patch74-20260530-drm-no-more-bridge-reset-v1-74-875d828d31bc@kernel.org> (raw)
In-Reply-To: <20260530-drm-no-more-bridge-reset-v1-74-875d828d31bc@kernel.org>
Patch Review
Converts cdns-dsi and fixes the error return:
```c
- return NULL;
+ return ERR_PTR(-ENOMEM);
```
The old `atomic_reset` contract allowed returning NULL (though it was technically wrong -- the docs said to return ERR_PTR). The new `atomic_create_state` contract requires ERR_PTR. This fix is correct and necessary.
No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 5:45 UTC|newest]
Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 13:59 [PATCH 00/76] drm/bridge: Convert all reset users to create_state Maxime Ripard
2026-05-30 13:59 ` [PATCH 01/76] drm/atomic-state-helper: Rename __drm_atomic_helper_bridge_reset() Maxime Ripard
2026-06-02 7:03 ` Thomas Zimmermann
2026-06-03 14:07 ` Luca Ceresoli
2026-06-04 5:45 ` Claude review: " Claude Code Review Bot
2026-05-30 13:59 ` [PATCH 02/76] drm/atomic-state-helper: Reorder __drm_atomic_helper_bridge_state_init() arguments Maxime Ripard
2026-06-02 7:03 ` Thomas Zimmermann
2026-06-04 5:45 ` Claude review: " Claude Code Review Bot
2026-05-30 13:59 ` [PATCH 03/76] drm/atomic-state-helper: Drop memset from __drm_atomic_helper_bridge_state_init() Maxime Ripard
2026-06-02 7:06 ` Thomas Zimmermann
2026-06-03 14:07 ` Luca Ceresoli
2026-06-04 5:45 ` Claude review: " Claude Code Review Bot
2026-05-30 13:59 ` [PATCH 04/76] drm/bridge: Add new atomic_create_state callback Maxime Ripard
2026-05-31 3:15 ` Liu Ying
2026-06-02 7:24 ` Thomas Zimmermann
2026-06-02 7:26 ` Maxime Ripard
2026-06-04 5:45 ` Claude review: " Claude Code Review Bot
2026-05-30 13:59 ` [PATCH 05/76] drm/atomic-state-helper: Add drm_atomic_helper_bridge_create_state() Maxime Ripard
2026-06-02 7:35 ` Thomas Zimmermann
2026-06-03 14:07 ` Luca Ceresoli
2026-06-04 5:45 ` Claude review: " Claude Code Review Bot
2026-05-30 13:59 ` [PATCH 06/76] drm/bridge: adv7511: Switch to atomic_create_state Maxime Ripard
2026-05-30 13:59 ` [PATCH 07/76] drm/bridge: analogix_dp: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 08/76] drm/bridge: anx7625: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 09/76] drm/bridge: chipone-icn6211: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 10/76] drm/bridge: display-connector: " Maxime Ripard
2026-06-03 14:07 ` Luca Ceresoli
2026-05-30 13:59 ` [PATCH 11/76] drm/bridge: fsl-ldb: " Maxime Ripard
2026-06-03 14:07 ` Luca Ceresoli
2026-05-30 13:59 ` [PATCH 12/76] drm/bridge: imx8mp-hdmi-pvi: " Maxime Ripard
2026-06-03 14:07 ` Luca Ceresoli
2026-05-30 13:59 ` [PATCH 13/76] drm/bridge: imx8qm-ldb: " Maxime Ripard
2026-06-03 14:07 ` Luca Ceresoli
2026-05-30 13:59 ` [PATCH 14/76] drm/bridge: imx8qxp-ldb: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 15/76] drm/bridge: imx8qxp-pixel-combiner: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 16/76] drm/bridge: imx8qxp-pixel-link: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 17/76] drm/bridge: imx8qxp-pxl2dpi: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 18/76] drm/bridge: inno-hdmi: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 19/76] drm/bridge: ite-it6263: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 20/76] drm/bridge: ite-it6505: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 21/76] drm/bridge: ite-it66121: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 22/76] drm/bridge: lontium-lt9211: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 23/76] drm/bridge: lontium-lt9611: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 24/76] drm/bridge: lvds-codec: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 25/76] drm/bridge: nwl-dsi: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 26/76] drm/bridge: panel: " Maxime Ripard
2026-06-03 14:07 ` Luca Ceresoli
2026-05-30 13:59 ` [PATCH 27/76] drm/bridge: parade-ps8640: " Maxime Ripard
2026-06-02 0:20 ` Doug Anderson
2026-05-30 13:59 ` [PATCH 28/76] drm/bridge: samsung-dsim: " Maxime Ripard
2026-06-03 14:07 ` Luca Ceresoli
2026-05-30 13:59 ` [PATCH 29/76] drm/bridge: sii902x: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 30/76] drm/bridge: ssd2825: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 31/76] drm/bridge: dw-dp: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 32/76] drm/bridge: dw-hdmi-qp: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 33/76] drm/bridge: dw-hdmi: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 34/76] drm/bridge: dw-mipi-dsi: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 35/76] drm/bridge: dw-mipi-dsi2: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 36/76] drm/bridge: tc358762: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 37/76] drm/bridge: tc358767: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 38/76] drm/bridge: tc358768: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 39/76] drm/bridge: tc358775: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 40/76] drm/bridge: ti-dlpc3433: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 41/76] drm/bridge: ti-sn65dsi83: " Maxime Ripard
2026-06-03 14:07 ` Luca Ceresoli
2026-05-30 13:59 ` [PATCH 42/76] drm/bridge: ti-sn65dsi86: " Maxime Ripard
2026-06-02 0:19 ` Doug Anderson
2026-06-03 14:07 ` Luca Ceresoli
2026-05-30 13:59 ` [PATCH 43/76] drm/bridge: ti-tdp158: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 44/76] drm/bridge: ti-tfp410: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 45/76] drm/imx: parallel-display: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 46/76] drm/ingenic: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 47/76] drm/mediatek: dp: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 48/76] drm/mediatek: dpi: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 49/76] drm/mediatek: dsi: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 50/76] drm/mediatek: hdmi: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 51/76] drm/mediatek: hdmi_v2: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 52/76] drm/meson: encoder_cvbs: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 53/76] drm/meson: encoder_dsi: " Maxime Ripard
2026-05-30 13:59 ` [PATCH 54/76] drm/meson: encoder_hdmi: " Maxime Ripard
2026-05-30 14:00 ` [PATCH 55/76] drm/msm: dp: " Maxime Ripard
2026-05-30 14:00 ` [PATCH 56/76] drm/msm: hdmi: " Maxime Ripard
2026-05-30 14:00 ` [PATCH 57/76] drm/omap: hdmi4: " Maxime Ripard
2026-05-30 14:00 ` [PATCH 58/76] drm/omap: hdmi5: " Maxime Ripard
2026-05-30 14:00 ` [PATCH 59/76] drm/renesas: rcar-du: lvds: " Maxime Ripard
2026-05-30 14:00 ` [PATCH 60/76] drm/renesas: rcar-du: mipi_dsi: " Maxime Ripard
2026-05-30 14:00 ` [PATCH 61/76] drm/renesas: rz-du: " Maxime Ripard
2026-05-30 14:00 ` [PATCH 62/76] drm/rockchip: cdn-dp: " Maxime Ripard
2026-06-02 15:02 ` Heiko Stuebner
2026-05-30 14:00 ` [PATCH 63/76] drm/rockchip: rk3066_hdmi: " Maxime Ripard
2026-06-02 15:02 ` Heiko Stuebner
2026-05-30 14:00 ` [PATCH 64/76] drm/rockchip: lvds: " Maxime Ripard
2026-06-02 15:03 ` Heiko Stuebner
2026-05-30 14:00 ` [PATCH 65/76] drm/stm: " Maxime Ripard
2026-05-30 14:00 ` [PATCH 66/76] drm/tests: bridge: " Maxime Ripard
2026-05-30 14:00 ` [PATCH 67/76] drm/tidss: encoder: " Maxime Ripard
2026-05-30 14:00 ` [PATCH 68/76] drm/tidss: oldi: " Maxime Ripard
2026-05-30 14:00 ` [PATCH 69/76] drm/vc4: dsi: " Maxime Ripard
2026-06-01 14:32 ` Maíra Canal
2026-06-01 14:59 ` Dave Stevenson
2026-05-30 14:00 ` [PATCH 70/76] drm/verisilicon: " Maxime Ripard
2026-05-31 10:08 ` Icenowy Zheng
2026-05-30 14:00 ` [PATCH 71/76] drm/xlnx: zynqmp_dp: " Maxime Ripard
2026-06-03 14:07 ` Luca Ceresoli
2026-05-30 14:00 ` [PATCH 72/76] drm/atomic-state-helper: Remove drm_atomic_helper_bridge_reset() Maxime Ripard
2026-06-02 7:36 ` Thomas Zimmermann
2026-06-04 5:45 ` Claude review: " Claude Code Review Bot
2026-05-30 14:00 ` [PATCH 73/76] drm/bridge: cdns-dsi: Use __drm_atomic_helper_bridge_state_init() Maxime Ripard
2026-06-04 5:45 ` Claude review: " Claude Code Review Bot
2026-05-30 14:00 ` [PATCH 74/76] drm/bridge: cdns-dsi: Switch to atomic_create_state Maxime Ripard
2026-06-02 7:39 ` Thomas Zimmermann
2026-06-04 5:45 ` Claude Code Review Bot [this message]
2026-05-30 14:00 ` [PATCH 75/76] drm/bridge: cdns-mhdp8546: " Maxime Ripard
2026-06-02 8:00 ` Thomas Zimmermann
2026-06-04 5:45 ` Claude review: " Claude Code Review Bot
2026-05-30 14:00 ` [PATCH 76/76] drm/bridge: Remove atomic_reset support Maxime Ripard
2026-06-04 5:45 ` Claude review: " Claude Code Review Bot
2026-06-04 5:45 ` Claude review: drm/bridge: Convert all reset users to create_state Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch74-20260530-drm-no-more-bridge-reset-v1-74-875d828d31bc@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox