From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: Remove atomic_reset support Date: Thu, 04 Jun 2026 15:45:43 +1000 Message-ID: In-Reply-To: <20260530-drm-no-more-bridge-reset-v1-76-875d828d31bc@kernel.org> References: <20260530-drm-no-more-bridge-reset-v1-0-875d828d31bc@kernel.org> <20260530-drm-no-more-bridge-reset-v1-76-875d828d31bc@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Removes the fallback and the dual-check: ```c - if (bridge->funcs->atomic_create_state) - state = bridge->funcs->atomic_create_state(bridge); - else - state = bridge->funcs->atomic_reset(bridge); + state = bridge->funcs->atomic_create_state(bridge); ``` ```c - return (bridge->funcs->atomic_create_state || - bridge->funcs->atomic_reset); + return bridge->funcs->atomic_create_state != NULL; ``` This is correct *given that all drivers have been converted*. But note: this patch only modifies `drm_bridge.c` -- it does **not** remove `atomic_reset` from `struct drm_bridge_funcs` in `drm_bridge.h`. If patch 4 is fixed to keep both fields (as recommended above), then patch 76 should also include the removal of `atomic_reset` from the struct definition. --- **Summary:** The series is well-motivated and well-structured overall. The mechanical conversions are all correct. The main issue is a bisectability problem in patch 4 where `atomic_reset` is prematurely removed from the struct definition. Patch 4 needs to be reworked to keep both callback fields during the transition, and patch 76 needs to include the struct field removal. --- Generated by Claude Code Patch Reviewer