From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: analogix_dp: Remove unused &analogix_dp_plat_data.get_modes()
Date: Wed, 11 Feb 2026 16:37:17 +1000 [thread overview]
Message-ID: <review-patch8-20260210071225.2566099-9-damon.ding@rock-chips.com> (raw)
In-Reply-To: <20260210071225.2566099-9-damon.ding@rock-chips.com>
Patch Review
**Summary:** Removes unused callback after previous refactoring.
```c
- if (dp->plat_data->get_modes)
- num_modes += dp->plat_data->get_modes(dp->plat_data, connector);
```
**Review:** Dead code removal after PATCH 5 and 7 eliminated all implementations.
**Verdict:** Approved, good cleanup.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-11 6:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 7:12 [PATCH v9 00/15] Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver Damon Ding
2026-02-10 7:12 ` [PATCH v9 01/15] drm/bridge: analogix_dp: Add &analogix_dp_plat_data.next_bridge Damon Ding
2026-02-11 6:37 ` Claude review: " Claude Code Review Bot
2026-02-10 7:12 ` [PATCH v9 02/15] drm/bridge: Move legacy bridge driver out of imx directory for multi-platform use Damon Ding
2026-02-11 6:37 ` Claude review: " Claude Code Review Bot
2026-02-10 7:12 ` [PATCH v9 03/15] drm/exynos: exynos_dp: Remove &exynos_dp_device.ptn_bridge Damon Ding
2026-02-11 6:37 ` Claude review: " Claude Code Review Bot
2026-02-10 7:12 ` [PATCH v9 04/15] drm/exynos: exynos_dp: Remove unused &exynos_dp_device.connector Damon Ding
2026-02-11 6:37 ` Claude review: " Claude Code Review Bot
2026-02-10 7:12 ` [PATCH v9 05/15] drm/exynos: exynos_dp: Apply of-display-mode-bridge to parse the display-timings node Damon Ding
2026-02-11 6:37 ` Claude review: " Claude Code Review Bot
2026-02-10 7:12 ` [PATCH v9 06/15] drm/bridge: analogix_dp: Remove redundant &analogix_dp_plat_data.skip_connector Damon Ding
2026-02-11 6:37 ` Claude review: " Claude Code Review Bot
2026-02-10 7:12 ` [PATCH v9 07/15] drm/bridge: analogix_dp: Move the color format check to .atomic_check() for Rockchip platforms Damon Ding
2026-02-11 6:37 ` Claude review: " Claude Code Review Bot
2026-02-10 7:12 ` [PATCH v9 08/15] drm/bridge: analogix_dp: Remove unused &analogix_dp_plat_data.get_modes() Damon Ding
2026-02-11 6:37 ` Claude Code Review Bot [this message]
2026-02-10 7:12 ` [PATCH v9 09/15] drm/bridge: analogix_dp: Apply drm_bridge_connector helper Damon Ding
2026-02-11 6:37 ` Claude review: " Claude Code Review Bot
2026-02-10 7:12 ` [PATCH v9 10/15] drm/bridge: analogix_dp: Add new API analogix_dp_finish_probe() Damon Ding
2026-02-11 6:37 ` Claude review: " Claude Code Review Bot
2026-02-10 7:12 ` [PATCH v9 11/15] drm/rockchip: analogix_dp: Apply analogix_dp_finish_probe() Damon Ding
2026-02-11 6:37 ` Claude review: " Claude Code Review Bot
2026-02-10 7:12 ` [PATCH v9 12/15] drm/exynos: exynos_dp: " Damon Ding
2026-02-11 6:37 ` Claude review: " Claude Code Review Bot
2026-02-10 7:12 ` [PATCH v9 13/15] drm/bridge: analogix_dp: Attach the next bridge in analogix_dp_bridge_attach() Damon Ding
2026-02-11 6:37 ` Claude review: " Claude Code Review Bot
2026-02-10 9:10 ` [PATCH v9 14/15] drm/bridge: analogix_dp: Remove bridge disabing and panel unpreparing in analogix_dp_unbind() Damon Ding
2026-02-10 9:10 ` [PATCH v9 15/15] drm/bridge: analogix_dp: Apply panel_bridge helper Damon Ding
2026-02-11 6:37 ` Claude review: " Claude Code Review Bot
2026-02-11 6:37 ` Claude review: drm/bridge: analogix_dp: Remove bridge disabing and panel unpreparing in analogix_dp_unbind() Claude Code Review Bot
2026-02-11 6:37 ` Claude review: Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch8-20260210071225.2566099-9-damon.ding@rock-chips.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox