public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: gsp: use available device reference
Date: Tue, 17 Feb 2026 15:48:08 +1000	[thread overview]
Message-ID: <review-patch8-20260217-nova-misc-v3-8-b4e2d45eafbc@nvidia.com> (raw)
In-Reply-To: <20260217-nova-misc-v3-8-b4e2d45eafbc@nvidia.com>

Patch Review

This patch replaces `pdev.as_ref()` with `dev` in the `boot` method, where `dev` is already defined as `let dev = pdev.as_ref()` at the top of the function. The one place where `pdev.as_ref().into()` was used is changed to `dev.into()`.

> -        dev: pdev.as_ref().into(),
> +        dev: dev.into(),

I notice a pre-existing issue in the format string that the patch carries forward:

> +        dev_dbg!(dev, "SEC2 MBOX0: {:#x}, MBOX1{:#x}\n", mbox0, mbox1);

There's a missing colon and space after `MBOX1` - it reads `MBOX1{:#x}` instead of `MBOX1: {:#x}`. This exists in the original code too, so it's not introduced by this patch, but it might be worth a drive-by fix since the line is already being modified.

Also, there's a trailing comma in the reformatted debug line:

> +        dev_dbg!(dev, "RISC-V active? {}\n", gsp_falcon.is_riscv_active(bar),);

The trailing comma before `)` is valid Rust syntax (trailing commas are allowed in macro invocations), so this is purely a style observation. It appears to be an artifact of reformatting the multi-line original into a single line.

No correctness issues found.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-02-17  5:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-17  2:45 [PATCH v3 0/8] gpu: nova-core: miscellaneous improvements Alexandre Courbot
2026-02-17  2:45 ` [PATCH v3 1/8] gpu: nova-core: gsp: warn if data remains after processing a message Alexandre Courbot
2026-02-17  5:48   ` Claude review: " Claude Code Review Bot
2026-02-17  2:45 ` [PATCH v3 2/8] gpu: nova-core: gsp: remove unnecessary Display impls Alexandre Courbot
2026-02-17  5:48   ` Claude review: " Claude Code Review Bot
2026-02-17  2:45 ` [PATCH v3 3/8] gpu: nova-core: gsp: simplify sequencer opcode parsing Alexandre Courbot
2026-02-17  5:48   ` Claude review: " Claude Code Review Bot
2026-02-17  2:45 ` [PATCH v3 4/8] gpu: nova-core: gsp: remove unneeded sequencer trait Alexandre Courbot
2026-02-17  5:48   ` Claude review: " Claude Code Review Bot
2026-02-17  2:45 ` [PATCH v3 5/8] gpu: nova-core: gsp: derive `Debug` on more sequencer types Alexandre Courbot
2026-02-17  5:48   ` Claude review: " Claude Code Review Bot
2026-02-17  2:45 ` [PATCH v3 6/8] gpu: nova-core: gsp: derive Zeroable for GspStaticConfigInfo Alexandre Courbot
2026-02-17  5:48   ` Claude review: " Claude Code Review Bot
2026-02-17  2:45 ` [PATCH v3 7/8] gpu: nova-core: use core library's CStr instead of kernel one Alexandre Courbot
2026-02-17  5:48   ` Claude review: " Claude Code Review Bot
2026-02-17  2:45 ` [PATCH v3 8/8] gpu: nova-core: gsp: use available device reference Alexandre Courbot
2026-02-17  5:48   ` Claude Code Review Bot [this message]
2026-02-17  5:48 ` Claude review: gpu: nova-core: miscellaneous improvements Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch8-20260217-nova-misc-v3-8-b4e2d45eafbc@nvidia.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox