From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: use available device reference Date: Tue, 17 Feb 2026 15:48:08 +1000 Message-ID: In-Reply-To: <20260217-nova-misc-v3-8-b4e2d45eafbc@nvidia.com> References: <20260217-nova-misc-v3-0-b4e2d45eafbc@nvidia.com> <20260217-nova-misc-v3-8-b4e2d45eafbc@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This patch replaces `pdev.as_ref()` with `dev` in the `boot` method, where `dev` is already defined as `let dev = pdev.as_ref()` at the top of the function. The one place where `pdev.as_ref().into()` was used is changed to `dev.into()`. > - dev: pdev.as_ref().into(), > + dev: dev.into(), I notice a pre-existing issue in the format string that the patch carries forward: > + dev_dbg!(dev, "SEC2 MBOX0: {:#x}, MBOX1{:#x}\n", mbox0, mbox1); There's a missing colon and space after `MBOX1` - it reads `MBOX1{:#x}` instead of `MBOX1: {:#x}`. This exists in the original code too, so it's not introduced by this patch, but it might be worth a drive-by fix since the line is already being modified. Also, there's a trailing comma in the reformatted debug line: > + dev_dbg!(dev, "RISC-V active? {}\n", gsp_falcon.is_riscv_active(bar),); The trailing comma before `)` is valid Rust syntax (trailing commas are allowed in macro invocations), so this is purely a style observation. It appears to be an artifact of reformatting the multi-line original into a single line. No correctness issues found. --- Generated by Claude Code Patch Reviewer