From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: ARM: dts: ti: omap: samsung-espresso10: Add initial support for Galaxy Tab 2 10.1 Date: Mon, 23 Feb 2026 06:16:29 +1000 Message-ID: In-Reply-To: <20260219210408.5451-9-bavishimithil@gmail.com> References: <20260219210408.5451-1-bavishimithil@gmail.com> <20260219210408.5451-9-bavishimithil@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review > + //avdd-supply = <®_touch_ldo_en>; > + vdd-supply = <&ldo6>; Commented-out code should not be submitted. If this supply connection is unknown or needs investigation, a `/* TODO: ... */` comment explaining why it's missing would be more appropriate than leaving the property commented out. As-is, it looks like debugging leftover. > +#include "omap4-samsung-espresso-common.dtsi" > +#include > +/ { Missing a blank line between the `#include` and the `/ {` root node for readability (the espresso7 variant has this blank line). The SMB347 charger node at address 0x6 (from 7-bit I2C address 0x0C >> 1) looks correct for the summit,smb347 binding. --- Generated by Claude Code Patch Reviewer