From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: synopsys: dw-dp: Convert to drm_output_color_format Date: Fri, 27 Feb 2026 15:17:09 +1000 Message-ID: In-Reply-To: <20260224-drm-rework-color-formats-v1-8-bebc76604ada@kernel.org> References: <20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org> <20260224-drm-rework-color-formats-v1-8-bebc76604ada@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The largest driver conversion. This is a good example of proper dual-context handling: - `struct dw_dp_output_format` field changed to `enum drm_output_color_format` - Initializer table uses bare enum values (discriminant context) - Switch cases use bare enum values - Bitmask comparisons against `info->color_formats` correctly use `BIT()` - The function signature `dw_dp_video_set_msa()` is correctly updated The `dw_dp_bridge_atomic_get_output_bus_fmts()` change at line 1501-1502 is notable: ```c - if (!(fmt->color_format & di->color_formats)) + if (!(BIT(fmt->color_format) & di->color_formats)) ``` This correctly wraps the now-enum field in `BIT()` before testing against the bitmask. **Same commit message typos.** --- Generated by Claude Code Patch Reviewer