From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: ARM: dts: imx6ul-var-som: factor out SD card support Date: Tue, 03 Mar 2026 12:58:06 +1000 Message-ID: In-Reply-To: <20260302190953.669325-9-hugo@hugovil.com> References: <20260302190953.669325-1-hugo@hugovil.com> <20260302190953.669325-9-hugo@hugovil.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Factors SD card into `imx6ul-var-som-sd.dtsi`. The `pinctrl_usdhc1*` definitions are moved to `imx6ul-var-som-common.dtsi` while the SD-specific GPIO CD pin and the `&usdhc1` configuration go into the SD-specific dtsi. This makes sense since the same USDHC1 pins are shared between SD and WiFi. The `pinctrl_usdhc1_gpio` with the CD pin staying in the sd.dtsi is correct since WiFi uses don't need the CD pin. --- Generated by Claude Code Patch Reviewer