From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: ARM: dts: ti: omap: samsung-espresso10: Add initial support for Galaxy Tab 2 10.1 Date: Wed, 04 Mar 2026 06:45:51 +1000 Message-ID: In-Reply-To: <20260303203017.511-9-bavishimithil@gmail.com> References: <20260303203017.511-1-bavishimithil@gmail.com> <20260303203017.511-9-bavishimithil@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Commented-out code should not be submitted upstream:** ``` //avdd-supply =3D <®_touch_ldo_en>; ``` This commented-out supply reference should either be removed or properly en= abled. If it's a known TODO, add a comment explaining why (similar to the `= /* TODO: ... */` pattern used elsewhere in the series). **Missing `syncclk-active` in panel-timing:** The espresso7 panel-timing includes `syncclk-active =3D <0>;` but espresso1= 0 does not. This may be intentional but should be verified =E2=80=94 if the= LTN101AL03 panel needs the same property, it should be added. **Missing blank line after `#include`:** ``` #include / { ``` There should be a blank line between the `#include` and the root node for r= eadability. **Makefile ordering:** Same issue as patch 7 =E2=80=94 the samsung entries = are not in the correct alphabetical position. --- Generated by Claude Code Patch Reviewer