public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/mode-config: Create drm_mode_config_create_state()
Date: Wed, 11 Mar 2026 13:09:08 +1000	[thread overview]
Message-ID: <review-patch8-20260310-drm-mode-config-init-v1-8-de7397c8e1cf@kernel.org> (raw)
In-Reply-To: <20260310-drm-mode-config-init-v1-8-de7397c8e1cf@kernel.org>

Patch Review

**Bug: Missing `drm_connector_list_iter_end()` on error path.** In `drm_mode_config_create_state()`:
```c
	drm_connector_list_iter_begin(dev, &conn_iter);
	drm_for_each_connector_iter(connector, &conn_iter) {
		if (connector->state)
			continue;

		ret = drm_mode_config_connector_create_state(connector);
		if (ret)
			return ret;   // <-- leaks the connector iterator!
	}
	drm_connector_list_iter_end(&conn_iter);
```
If `drm_mode_config_connector_create_state()` fails, the function returns without calling `drm_connector_list_iter_end()`, which will leak the connector list iteration reference. This needs a `goto` to a cleanup label.

Additionally, the function has **no cleanup on partial failure** for any of the earlier loops either. If e.g. crtc state allocation fails after plane states were successfully allocated, those plane states are leaked. The function probably needs either full rollback or should be documented as leaving partial state that the caller must handle.

The `// TODO: Implement atomic_create_state for colorop.` comment with a fallback to `drm_colorop_reset()` is fine for now but should be tracked.

The doc update to the state lifetime documentation is good, clearly separating "initialization time" from "reset time".

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-11  3:09 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-10 16:06 [PATCH 00/14] drm/atomic: Rework initial state allocation Maxime Ripard
2026-03-10 16:06 ` [PATCH 01/14] drm/atomic: Document atomic state lifetime Maxime Ripard
2026-03-11  3:09   ` Claude review: " Claude Code Review Bot
2026-03-10 16:06 ` [PATCH 02/14] drm/atomic: Drop drm_private_state.obj assignment from create_state Maxime Ripard
2026-03-11  3:09   ` Claude review: " Claude Code Review Bot
2026-03-10 16:06 ` [PATCH 03/14] drm/mode-config: Mention drm_mode_config_reset() culprits Maxime Ripard
2026-03-11  3:09   ` Claude review: " Claude Code Review Bot
2026-03-10 16:06 ` [PATCH 04/14] drm/atomic-state-helper: Fix __drm_atomic_helper_plane_reset() doc typo Maxime Ripard
2026-03-11  3:09   ` Claude review: " Claude Code Review Bot
2026-03-10 16:06 ` [PATCH 05/14] drm/plane: Add new atomic_create_state callback Maxime Ripard
2026-03-11  3:09   ` Claude review: " Claude Code Review Bot
2026-03-10 16:06 ` [PATCH 06/14] drm/crtc: " Maxime Ripard
2026-03-11  3:09   ` Claude review: " Claude Code Review Bot
2026-03-10 16:06 ` [PATCH 07/14] drm/connector: " Maxime Ripard
2026-03-11  3:09   ` Claude review: " Claude Code Review Bot
2026-03-10 16:07 ` [PATCH 08/14] drm/mode-config: Create drm_mode_config_create_state() Maxime Ripard
2026-03-11  3:09   ` Claude Code Review Bot [this message]
2026-03-10 16:07 ` [PATCH 09/14] drm/drv: Call drm_mode_config_create_state() by default Maxime Ripard
2026-03-11  3:09   ` Claude review: " Claude Code Review Bot
2026-03-10 16:07 ` [PATCH 10/14] drm/atomic: Drop private obj state allocation Maxime Ripard
2026-03-11  3:09   ` Claude review: " Claude Code Review Bot
2026-03-10 16:07 ` [PATCH 11/14] drm/drv: Drop drm_mode_config_reset() from our skeleton Maxime Ripard
2026-03-11  3:09   ` Claude review: " Claude Code Review Bot
2026-03-10 16:07 ` [PATCH 12/14] drm/tidss: Drop call to drm_mode_config_reset at probe time Maxime Ripard
2026-03-11  3:09   ` Claude review: " Claude Code Review Bot
2026-03-10 16:07 ` [PATCH 13/14] drm/tidss: Convert to atomic_create_state Maxime Ripard
2026-03-11  3:09   ` Claude review: " Claude Code Review Bot
2026-03-10 16:07 ` [PATCH 14/14] drm/bridge_connector: " Maxime Ripard
2026-03-11  3:09   ` Claude review: " Claude Code Review Bot
2026-03-11  3:09 ` Claude review: drm/atomic: Rework initial state allocation Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-20 16:27 [PATCH v2 00/20] " Maxime Ripard
2026-03-20 16:27 ` [PATCH v2 14/20] drm/mode-config: Create drm_mode_config_create_state() Maxime Ripard
2026-03-21 17:32   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch8-20260310-drm-mode-config-init-v1-8-de7397c8e1cf@kernel.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox