From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: Use trace_invoke_##name() at guarded tracepoint call sites
Date: Fri, 13 Mar 2026 14:04:53 +1000 [thread overview]
Message-ID: <review-patch8-20260312150523.2054552-9-vineeth@bitbyteword.org> (raw)
In-Reply-To: <20260312150523.2054552-9-vineeth@bitbyteword.org>
Patch Review
Simple conversion of 2 call sites in `drivers/dma-buf/dma-fence.c`:
- Line 553: `trace_dma_fence_wait_start()` → `trace_invoke_dma_fence_wait_start()`, guarded by `trace_dma_fence_wait_start_enabled()` ✓
- Line 562: `trace_dma_fence_wait_end()` → `trace_invoke_dma_fence_wait_end()`, guarded by `trace_dma_fence_wait_end_enabled()` ✓
Both call sites also have explicit `rcu_read_lock()`/`rcu_read_unlock()` around them. Since `__do_trace_##name()` now uses `guard(srcu_fast_notrace)` internally (not classic RCU), the existing `rcu_read_lock()` guards are superfluous for the trace call itself but may exist for other reasons (e.g., the fence object stability). This is a pre-existing pattern, not introduced by this patch.
No issues with this patch.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-13 4:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 15:04 [PATCH 00/15] tracepoint: Avoid double static_branch evaluation at guarded call sites Vineeth Pillai (Google)
2026-03-12 15:04 ` [PATCH 01/15] tracepoint: Add trace_invoke_##name() API Vineeth Pillai (Google)
2026-03-12 15:12 ` Steven Rostedt
2026-03-12 15:39 ` Vineeth Remanan Pillai
2026-03-12 15:53 ` Peter Zijlstra
2026-03-12 16:05 ` Vineeth Remanan Pillai
2026-03-13 4:04 ` Claude review: " Claude Code Review Bot
2026-03-12 15:05 ` [PATCH 05/15] accel/habanalabs: Use trace_invoke_##name() at guarded tracepoint call sites Vineeth Pillai (Google)
2026-03-13 4:04 ` Claude review: " Claude Code Review Bot
2026-03-12 15:05 ` [PATCH 08/15] dma-buf: " Vineeth Pillai (Google)
2026-03-13 4:04 ` Claude Code Review Bot [this message]
2026-03-12 15:05 ` [PATCH 10/15] drm: " Vineeth Pillai (Google)
2026-03-13 4:04 ` Claude review: " Claude Code Review Bot
2026-03-12 15:12 ` [PATCH 00/15] tracepoint: Avoid double static_branch evaluation at guarded " Mathieu Desnoyers
2026-03-12 15:23 ` Steven Rostedt
2026-03-12 15:28 ` Mathieu Desnoyers
2026-03-12 15:40 ` Steven Rostedt
2026-03-12 15:49 ` Mathieu Desnoyers
2026-03-12 15:54 ` Peter Zijlstra
2026-03-12 15:57 ` Mathieu Desnoyers
2026-03-12 16:08 ` Vineeth Remanan Pillai
[not found] ` <CAEf4BzbnfyhCqp0ne=2gRnVxp-mdGmuZwDeFRyhRYH+eDcz2-w@mail.gmail.com>
2026-03-12 17:02 ` Steven Rostedt
2026-03-13 4:04 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch8-20260312150523.2054552-9-vineeth@bitbyteword.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox