From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: PCI: Remove device links to PHY
Date: Sun, 22 Mar 2026 04:07:13 +1000 [thread overview]
Message-ID: <review-patch8-20260319223241.1351137-9-vladimir.oltean@nxp.com> (raw)
In-Reply-To: <20260319223241.1351137-9-vladimir.oltean@nxp.com>
Patch Review
Removes redundant `device_link_add()`/`device_link_del()` calls from Cadence, DRA7xx, and Keystone PCI drivers. The commit message correctly explains these are redundant since commit 987351e1ea77 (2019) added automatic device links in PHY core. The cleanup is thorough -- removes the `struct device_link **link` members, allocation, creation, deletion, and error paths.
One observation in `pci-keystone.c`: the error label rename from `err_link` to `err` is fine since the link cleanup code was the only thing there.
Has Acked-by from Bjorn Helgaas. Looks good.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-21 18:07 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 22:32 [PATCH v5 phy-next 00/27] Split Generic PHY consumer and provider API Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 01/27] ata: add <linux/pm_runtime.h> where missing Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 02/27] PCI: Add missing headers transitively included by <linux/phy/phy.h> Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 03/27] usb: add " Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 04/27] drm: add <linux/pm_runtime.h> where missing Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 05/27] phy: " Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 06/27] phy: spacemit: include missing <linux/phy/phy.h> Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 07/27] net: lan969x: include missing <linux/of.h> Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 08/27] PCI: Remove device links to PHY Vladimir Oltean
2026-03-21 18:07 ` Claude Code Review Bot [this message]
2026-03-19 22:32 ` [PATCH v5 phy-next 09/27] scsi: ufs: exynos: stop poking into struct phy guts Vladimir Oltean
2026-03-20 2:15 ` Martin K. Petersen
2026-03-20 8:22 ` Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 10/27] scsi: ufs: qcom: keep parallel track of PHY power state Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 11/27] drm/rockchip: dw_hdmi: avoid direct dereference of phy->dev.of_node Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 12/27] usb: host: tegra: " Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 13/27] usb: gadget: tegra-xudc: " Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 14/27] drm/msm/dp: remove debugging prints with internal struct phy state Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 15/27] phy: move provider API out of public <linux/phy/phy.h> Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 16/27] phy: make phy_get_mode(), phy_(get|set)_bus_width() NULL tolerant Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 17/27] phy: introduce phy_get_max_link_rate() helper for consumers Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 18/27] drm/rockchip: dsi: include PHY provider header Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 19/27] drm: bridge: cdns-mhdp8546: use consumer API for getting PHY bus width Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 20/27] media: sunxi: a83-mips-csi2: include PHY provider header Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 21/27] net: renesas: rswitch: " Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 22/27] pinctrl: tegra-xusb: " Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 23/27] power: supply: cpcap-charger: include missing <linux/property.h> Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 24/27] phy: include PHY provider header (1/2) Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 25/27] phy: include PHY provider header (2/2) Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 26/27] phy: remove temporary provider compatibility from consumer header Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 ` [PATCH v5 phy-next 27/27] MAINTAINERS: add regexes for linux-phy Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
2026-03-21 18:07 ` Claude review: Split Generic PHY consumer and provider API Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-09 19:08 [PATCH v3 phy-next 00/24] " Vladimir Oltean
2026-03-09 19:08 ` [PATCH v3 phy-next 08/24] PCI: Remove device links to PHY Vladimir Oltean
2026-03-10 1:57 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch8-20260319223241.1351137-9-vladimir.oltean@nxp.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox