From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: PCI: Remove device links to PHY Date: Sun, 22 Mar 2026 04:07:13 +1000 Message-ID: In-Reply-To: <20260319223241.1351137-9-vladimir.oltean@nxp.com> References: <20260319223241.1351137-1-vladimir.oltean@nxp.com> <20260319223241.1351137-9-vladimir.oltean@nxp.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Removes redundant `device_link_add()`/`device_link_del()` calls from Cadence, DRA7xx, and Keystone PCI drivers. The commit message correctly explains these are redundant since commit 987351e1ea77 (2019) added automatic device links in PHY core. The cleanup is thorough -- removes the `struct device_link **link` members, allocation, creation, deletion, and error paths. One observation in `pci-keystone.c`: the error label rename from `err_link` to `err` is fine since the link cleanup code was the only thing there. Has Acked-by from Bjorn Helgaas. Looks good. --- Generated by Claude Code Patch Reviewer