From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/mxsfb/lcdif: use DRM_BRIDGE_ATTACH_NO_CONNECTOR and the bridge-connector Date: Sun, 22 Mar 2026 03:48:38 +1000 Message-ID: In-Reply-To: <20260320-drm-lcdif-dbanc-v1-8-479a04133e70@bootlin.com> References: <20260320-drm-lcdif-dbanc-v1-0-479a04133e70@bootlin.com> <20260320-drm-lcdif-dbanc-v1-8-479a04133e70@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This is the goal patch. The change is clean and follows the standard pattern: ```c ret = drm_bridge_attach(encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR); ... connector = drm_bridge_connector_init(lcdif->drm, encoder); ... ret = drm_connector_attach_encoder(connector, encoder); ``` The Kconfig `select DRM_BRIDGE_CONNECTOR` is correct. This looks good. All the preparatory work in patches 1-7 makes this final patch straightforward. --- Generated by Claude Code Patch Reviewer