From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/a6xx: Update HFI definitions Date: Wed, 25 Mar 2026 07:32:09 +1000 Message-ID: In-Reply-To: <20260324-a8xx-gpu-batch2-v1-8-fc95b8d9c017@oss.qualcomm.com> References: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> <20260324-a8xx-gpu-batch2-v1-8-fc95b8d9c017@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Adds new HFI feature constants, CLX table structures, and limits mitigation= table structures. The `#define` moves from local to header scope are clean. **Nit:** The `CLX_DATA` macro has a potential issue with operator precedenc= e =E2=80=94 the shifts should use parenthesized arguments: ```c #define CLX_DATA(irated, num_phases, clx_path, extd_intf) \ ((extd_intf << 29) | ... ``` Should be `(((extd_intf) << 29) | ((clx_path) << 28) | ...)` to be safe. Th= ough if this is only used with literal constants it's fine in practice. **Note:** There's a typo in the `a6xx_hfi_limits_cfg` docs: `"sid lievel"` = should be `"sid level"`. --- Generated by Claude Code Patch Reviewer