From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: imx8mp-hdmi-tx: add an hdmi-connector when missing using a DT overlay at boot time Date: Tue, 31 Mar 2026 16:54:44 +1000 Message-ID: In-Reply-To: <20260330-drm-lcdif-dbanc-v2-8-c7f2af536a24@bootlin.com> References: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> <20260330-drm-lcdif-dbanc-v2-8-c7f2af536a24@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Dead variable:** `hdmi_conn` is declared with `__free(device_node)` but i= s never assigned or used anywhere in the function. This should be removed. ```c struct device_node *hdmi_conn __free(device_node) =3D NULL; // unused ``` **Minor typos in commit message:** "device tre" should be "device tree", "i= sntantiating" should be "instantiating", "abd" should be "and". **Error handling for `of_overlay_fdt_apply`:** The function returns `of_ove= rlay_fdt_apply(...)` directly. If the overlay application fails, this retur= ns an error from a `subsys_initcall`, which will be logged but won't preven= t boot. This seems acceptable =E2=80=94 the HDMI output simply won't work, = which is a degraded but not catastrophic failure. **Hardcoded paths:** The code uses hardcoded DT paths like `/soc@0/bus@32c0= 0000/hdmi@32fd8000`. These are specific to the i.MX8MP SoC and the compatib= le check (`fsl,imx8mp-soc`) guards against running on other hardware. This = is reasonable for a fixup module. **Kconfig:** The `DRM_IMX8MP_DW_HDMI_BRIDGE_CONNECTOR_FIXUP` is a `bool` wi= th `default y` =E2=80=94 it's always built when both LCDIF and HDMI bridge = are enabled. The `select OF_OVERLAY` and `select DRM_DISPLAY_CONNECTOR` on = the parent config are appropriate. **The overlay itself** looks correct =E2=80=94 it adds the `fixup-hdmi-conn= ector` node at root level and adds a `port@1/endpoint` to the existing hdmi= node with proper remote-endpoint phandle linkage. --- Generated by Claude Code Patch Reviewer