From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/imagination: Minor improvements to job submission code documentation Date: Tue, 31 Mar 2026 17:33:25 +1000 Message-ID: In-Reply-To: <20260330-job-submission-fixes-cleanup-v1-8-7de8c09cef8c@imgtec.com> References: <20260330-job-submission-fixes-cleanup-v1-0-7de8c09cef8c@imgtec.com> <20260330-job-submission-fixes-cleanup-v1-8-7de8c09cef8c@imgtec.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status**: Good documentation cleanup. Fixes several things: - Typo `geomtry` -> `geometry` - Fixes broken kdoc comment for `pvr_queue_check_job_waiting_for_cccb_space()` (the old text had a dangling `pushed to the CCCB` fragment) - Clarifies `job_cmds_size()` comment to match the actual order of commands written - Reorders the return expression in `job_cmds_size()` to match CCCB write order (waits, job, signal) - nice touch for readability - Adds explanatory comments to `pvr_queue_get_paired_frag_job_dep()` and `pvr_queue_submit_job_to_cccb()` - Adds expanded doc for `to_pvr_queue_job_fence()` describing the three cases - Simplifies the `ROGUE_FWIF_CCB_CMD_MAX_UFOS` comment (removes historical context about sync prims that's no longer relevant) **No issues.** All changes are accurate improvements. --- Generated by Claude Code Patch Reviewer