From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dma-buf: heaps: system: Turn the heap into a module Date: Wed, 01 Apr 2026 07:50:37 +1000 Message-ID: In-Reply-To: <20260331-dma-buf-heaps-as-modules-v4-8-e18fda504419@kernel.org> References: <20260331-dma-buf-heaps-as-modules-v4-0-e18fda504419@kernel.org> <20260331-dma-buf-heaps-as-modules-v4-8-e18fda504419@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Same pattern as patch 7 for the system heap. Changes to tristate, adds MODULE macros. ```c MODULE_DESCRIPTION("DMA-BUF System Heap"); MODULE_LICENSE("GPL"); MODULE_IMPORT_NS("DMA_BUF"); MODULE_IMPORT_NS("DMA_BUF_HEAP"); ``` Same no-unload caveat as the CMA heap. No issues. --- **Summary:** The series is clean, well-organized, and achieves its goal with minimal changes. The only substantive concern is the potential for duplicate heap creation when the default CMA area is both in the `dma_contiguous_areas[]` list and handled separately by `add_cma_heaps()`, but this appears to be pre-existing behavior. The series is in good shape for merging. --- Generated by Claude Code Patch Reviewer