From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/dp: Fix readback for target_rr in Adaptive Sync SDP Date: Sun, 12 Apr 2026 12:51:26 +1000 Message-ID: In-Reply-To: <20260408084239.1295325-9-ankit.k.nautiyal@intel.com> References: <20260408084239.1295325-1-ankit.k.nautiyal@intel.com> <20260408084239.1295325-9-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **R-b: Ville Syrjala, Fixes tag present** This is a real bug fix. The old code: ```c as_sdp->target_rr = (u64)sdp->db[3] | ((u64)sdp->db[4] & 0x3); ``` is wrong -- it ORs db[4] bits[1:0] into bits[1:0] of db[3] instead of shifting them to bits[9:8]. The fix: ```c as_sdp->target_rr = ((sdp->db[4] & 0x3) << 8) | sdp->db[3]; ``` This matches the pack function which does `(as_sdp->target_rr >> 8) & 0x3` into db[4] and `target_rr & 0xFF` into db[3]. Good fix. Should be backported to stable. --- Generated by Claude Code Patch Reviewer