Claude review: Fix Adaptive-Sync SDP for PR with Link ON + Auxless-ALPM

Claude Code Review Bot
2026-04-12T02:51:24Z

Overall Series Review

Subject: Fix Adaptive-Sync SDP for PR with Link ON + Auxless-ALPM
Author: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Patches: 27
Reviewed: 2026-04-12T12:51:24.670746

---

This 26-patch series from Ankit Nautiyal enables Adaptive-Sync SDP for Panel Replay with Link ON and Auxless-ALPM on Intel display hardware. The series is well-structured, progressing from drm core cleanup/additions (patches 1-7), through i915-specific bug fixes and refactoring (patches 8-15), to new feature enablement (patches 16-26).

**Strengths:**
- Good separation of concerns: DRM core changes are cleanly separated from i915-specific logic.
- Many patches have been reviewed by Ville Syrjala, indicating upstream engagement.
- The commit messages are generally well-written with clear rationale and spec references.
- The split of AS SDP computation into early/late phases (patch 24) is a sound architectural decision.

**Concerns:**
- Patch 10 removes the `assume_all_enabled` path for AS SDP guardband without obvious justification for why that was wrong vs. just conservative.
- Patch 13 removes the revision check in unpack without replacing it with any validation, which is an intentional relaxation but worth noting.
- Patch 21 introduces a separate DPCD write for CONFIG3 right after patch 19 converted CONFIG/CONFIG2 to burst mode -- these could have been combined.
- Patch 26 widens AS SDP enablement to `intel_vrr_possible()` instead of `vrr.enable`, which is a semantic change worth scrutiny -- this enables AS SDP even when VRR is only possible but not currently active.

Overall the series is in reasonable shape. Most issues are minor.