From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/display: Switch to managed for connector Date: Sun, 12 Apr 2026 10:51:25 +1000 Message-ID: In-Reply-To: <20260409-feat_link_cap-v1-8-7069e8199ce2@bootlin.com> References: <20260409-feat_link_cap-v1-0-7069e8199ce2@bootlin.com> <20260409-feat_link_cap-v1-8-7069e8199ce2@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The overall approach is correct. The MST connector exception is well-motivated -- MST connectors have dynamic lifetimes managed by the topology layer. Concern about the `drmm_connector_init()` + `drmm_add_action_or_reset(intel_connector_destroy)` boilerplate repeated ~10 times. A helper like `drmm_intel_connector_init()` wrapping both calls would reduce duplication and the risk of one call being added without the other. The dual-use of `intel_connector_destroy()` as both a `drmm_action` callback `(struct drm_device *, void *)` and called directly from `mst_connector_destroy()` is functional but awkward. Consider a wrapper for the direct call path. --- Generated by Claude Code Patch Reviewer