Claude review: drm/msm/dp: splite msm_dp_ctrl_config_ctrl() into link parts and stream parts

Claude Code Review Bot
2026-04-12T00:16:12Z

Patch Review

**Typo in subject**: "splite" should be "split".

The split itself is correct — link-level config (LSCLK div, ASSR, lane count, enhanced framing) goes to `msm_dp_ctrl_config_ctrl_link()`, and stream-level config (YUV420 mode, BPC, VSC) goes to `msm_dp_ctrl_config_ctrl_streams()`. This separation is needed for MST where multiple streams share a single link configuration.

One concern: `msm_dp_ctrl_config_ctrl_streams()` does a read-modify-write:
```c
+ config = msm_dp_read_link(ctrl, REG_DP_CONFIGURATION_CTRL);
```
This reads back what `_link()` just wrote, then ORs in stream bits. This works but means the two functions are order-dependent — `_link()` must always be called before `_streams()`. A comment would help.

---
Generated by Claude Code Patch Reviewer