From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Use a local iomem base for MMU AS registers Date: Mon, 13 Apr 2026 19:05:53 +1000 Message-ID: In-Reply-To: <20260412142951.2309135-9-karunika.choo@arm.com> References: <20260412142951.2309135-1-karunika.choo@arm.com> <20260412142951.2309135-9-karunika.choo@arm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Good. Acked-by Boris Brezillon.** Adds `void __iomem *iomem` to `struct panthor_mmu`, set to `ptdev->iomem + = MMU_AS_BASE` (0x2400): ```c + mmu->iomem =3D ptdev->iomem + MMU_AS_BASE; ``` The `MMU_AS()` macro is rebased: ```c -#define MMU_AS(as) (MMU_BASE + ((as) << MMU_AS_SHIFT)) +#define MMU_AS(as) ((as) << MMU_AS_SHIFT) ``` Where `MMU_BASE` is renamed to `MMU_AS_BASE` (0x2400) and the AS-relative d= efines like `AS_TRANSTAB_LO`, `AS_COMMAND` etc. remain unchanged since they= were already relative to their address space slot. The MMU_INT IRQ iomem is set to `ptdev->iomem + MMU_INT_BASE` (0x2000). Cor= rect. No issues. --- ## SUMMARY | Patch | Verdict | Notes | |-------|---------|-------| | 1/8 | Clean | Mechanical refactor of helper signatures | | 2/8 | Clean | Header split, no logic changes | | 3/8 | Clean | Good encapsulation of cross-component accesses | | 4/8 | Clean | Minor: generic `INT_*` names could use prefix | | 5/8 | Clean | GPU iomem localization | | 6/8 | Clean | Pre-existing u64=E2=86=92u32 truncation in `panthor_pwr_l2_= power_on()` | | 7/8 | Clean | FW iomem localization | | 8/8 | Clean | MMU AS iomem localization | **Reviewed-by recommendation:** The series is sound. No functional regressi= ons introduced. The register arithmetic is verified correct across all patc= hes. The two observations (generic `INT_*` names, pre-existing u32 truncati= on) are non-blocking. --- Generated by Claude Code Patch Reviewer