From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/a6xx: Add yield & flush helper Date: Thu, 23 Apr 2026 09:13:15 +1000 Message-ID: In-Reply-To: <20260420222621.417276-9-robin.clark@oss.qualcomm.com> References: <20260420222621.417276-1-robin.clark@oss.qualcomm.com> <20260420222621.417276-9-robin.clark@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean refactor extracting the duplicated yield+flush sequence into `a6xx_flush_yield()`. Removes duplication from `a7xx_submit()`, `a7xx_preempt_start()`, and `a8xx_preempt_start()`. Minor nit: the `a7xx_preempt_start` version previously had `OUT_RING(ring, 0x00)` for dword[3] while the common version uses `OUT_RING(ring, 0x01)`. This changes the data value field for the preempt_start path. Since the address is 0 (skip write), this should be harmless, but worth verifying that the difference is intentional. --- Generated by Claude Code Patch Reviewer