From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: mm: Add GpuMm centralized memory manager Date: Tue, 28 Apr 2026 15:32:00 +1000 Message-ID: In-Reply-To: <20260425211454.174696-9-joelagnelf@nvidia.com> References: <20260425211454.174696-1-joelagnelf@nvidia.com> <20260425211454.174696-9-joelagnelf@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Introduces `GpuMm` owning `GpuBuddy`, `Pramin`, and `Tlb`. Refactors PRAMIN to use `bar.access(dev)` instead of `try_access()`. The PRAMIN region intentionally covers all physical VRAM (not just usable), since page tables themselves live outside the usable region. No significant issues. The `PraminWindow` lifetime change from `RevocableGuard` to `&Bar0` is a meaningful safety change that should be validated against the devres model. --- Generated by Claude Code Patch Reviewer