From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Use a local iomem base for MMU AS registers Date: Tue, 28 Apr 2026 14:28:33 +1000 Message-ID: In-Reply-To: <20260427155934.416502-9-karunika.choo@arm.com> References: <20260427155934.416502-1-karunika.choo@arm.com> <20260427155934.416502-9-karunika.choo@arm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `mmu->iomem = ptdev->iomem + MMU_AS_BASE` (0x2400). AS register macros are changed from absolute (`MMU_BASE + (as << shift)`) to relative (`(as << shift)`). MMU IRQ accesses go through `mmu->irq.iomem` with generic `INT_CLEAR`. The old `MMU_BASE` is renamed to `MMU_AS_BASE` and the old absolute `MMU_INT_*` macros are removed since IRQ accesses now use the generic `INT_*` offsets. No issues. --- **Summary**: Clean, well-organized refactoring series. The only actionable items are: 1. Patch 6 commit message typo ("PWR_CONTROl" -> "PWR_CONTROL"). 2. Patches 4 and 6 are missing review tags, which may need re-collection. 3. The generic `INT_RAWSTAT`/`INT_CLEAR`/`INT_MASK`/`INT_STAT` names in `panthor_device.h` are worth considering for a prefix, though this is minor. --- Generated by Claude Code Patch Reviewer