From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Automatically enable interrupts in panthor_fw_wait_acks() Date: Tue, 05 May 2026 11:44:54 +1000 Message-ID: In-Reply-To: <20260429-panthor-signal-from-irq-v1-8-4b92ae4142d2@collabora.com> References: <20260429-panthor-signal-from-irq-v1-0-4b92ae4142d2@collabora.com> <20260429-panthor-signal-from-irq-v1-8-4b92ae4142d2@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Verdict: Looks good with minor observations.** Instead of always enabling all IRQ masks for ack notifications, this patch only enables the relevant interrupt mask when the fast polling fails and the code needs to fall back to `wait_event_timeout`. This reduces unnecessary interrupt traffic. The changes to `cs_iface->input->ack_irq_mask` (from `~0` to `CS_FATAL | CS_FAULT | CS_TILER_OOM`) and `csg_iface->input->ack_irq_mask` (to `CSG_SYNC_UPDATE | CSG_IDLE | CSG_PROGRESS_TIMER_EVENT`) are sensible -- these are async events that can't be polled for. The `panthor_fw_wait_acks` interface change to pass `ack_irq_mask_ptr` and `lock` is clean. --- --- Generated by Claude Code Patch Reviewer