From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: PCI: Remove device links to PHY Date: Tue, 05 May 2026 10:35:02 +1000 Message-ID: In-Reply-To: <20260430110652.558622-9-vladimir.oltean@nxp.com> References: <20260430110652.558622-1-vladimir.oltean@nxp.com> <20260430110652.558622-9-vladimir.oltean@nxp.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This is the most substantial early patch. It reverts the manual `device_lin= k_add()` calls to PHY providers from 3 PCI controller drivers (cadence, dra= 7xx, keystone). Since commit 987351e1ea77 (2019), the PHY core adds device = links automatically, making these redundant. The diff correctly: - Removes `struct device_link **link` fields from structs and local variabl= es - Removes `device_link_add(dev, &phy[i]->dev, ...)` calls =E2=80=94 these d= irectly dereference `phy->dev`, which will become impossible - Removes `device_link_del()` in error paths and remove functions - Removes the now-unnecessary `#include ` from `pci-dra7xx.= c` - Simplifies the error handling in `ks_pcie_probe()` by renaming `err_link`= to just `err` - Removes dangling `phy_count` variable in `cdns_plat_pcie_probe()` Acked-by: Bjorn Helgaas, Reviewed-by: Manivannan Sadhasivam. Well done. --- Generated by Claude Code Patch Reviewer