From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: synopsys: dw-dp: Support software triggered OOB HPD Date: Tue, 05 May 2026 09:49:47 +1000 Message-ID: In-Reply-To: <20260501-synopsys-dw-dp-improvements-v2-8-d7e7f6bac77f@collabora.com> References: <20260501-synopsys-dw-dp-improvements-v2-0-d7e7f6bac77f@collabora.com> <20260501-synopsys-dw-dp-improvements-v2-8-d7e7f6bac77f@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Adds `hpd_sw_sel` and `hpd_sw_cfg` function pointers to `dw_dp_plat_data`: ```c + void *data; + void (*hpd_sw_sel)(void *data, bool hpd); + void (*hpd_sw_cfg)(void *data, bool hpd); ``` **Issue =E2=80=94 `dw_dp_bridge_oob_notify` always logs an error if no plat= form handler:** ```c + if (dp->plat_data.hpd_sw_cfg) + dp->plat_data.hpd_sw_cfg(dp->plat_data.data, hpd_high); + else + dev_err_once(dp->dev, "Missing platform handler for OOB HPD handling\n"); ``` The `oob_notify` callback is unconditionally registered in `dw_dp_bridge_fu= ncs`, so any platform using this bridge that receives an OOB event without = implementing `hpd_sw_cfg` will get an error. Since `oob_notify` is only cal= led for USB-C scenarios and the callback is only invoked if the connector g= ets an OOB event, this is probably fine in practice. But it might be cleane= r to only register `oob_notify` when the platform provides the handlers. **`dw_dp_is_routed_to_usb_c`** uses `drm_bridge_chain_get_last_bridge` with= `__free(drm_bridge_put)` =E2=80=94 the cleanup annotation is good. --- Generated by Claude Code Patch Reviewer