From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/a6xx: Add yield & flush helper Date: Tue, 05 May 2026 08:06:03 +1000 Message-ID: In-Reply-To: <20260504190751.61052-9-robin.clark@oss.qualcomm.com> References: <20260504190751.61052-1-robin.clark@oss.qualcomm.com> <20260504190751.61052-9-robin.clark@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Issue: Behavioral change in preempt_start paths.** The new `a6xx_flush_yield()` helper hardcodes dword[3] as `0x01`: ```c OUT_RING(ring, 0x01); ``` But the `a7xx_preempt_start()` and `a8xx_preempt_start()` code that is being replaced used `0x00` for dword[3]: ```c - OUT_RING(ring, 0x00); /* dword[3] was 0x00 in preempt_start */ ``` Meanwhile the `a7xx_submit()` path already used `0x01`. So this refactoring silently changes the preempt_start behavior. The comment says "Data value - not used if the address above is 0" so this is likely benign, but it should either be called out in the commit message as an intentional change, or the helper should accept the data value as a parameter to preserve the original behavior. --- Generated by Claude Code Patch Reviewer