From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: soc/tegra: pmc: Remove unused legacy functions Date: Thu, 07 May 2026 13:29:35 +1000 Message-ID: In-Reply-To: <20260506-pmc-v1-8-a6de5da7216b@nvidia.com> References: <20260506-pmc-v1-0-a6de5da7216b@nvidia.com> <20260506-pmc-v1-8-a6de5da7216b@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Straightforward removal of the legacy wrapper functions that were made unused by patches 1-6. Removes both the implementations in `pmc.c` and the declarations/stubs in `pmc.h`. Note: this also removes the `tegra_io_pad_get_voltage()` stub from `pmc.h`: ```c -static inline int tegra_io_pad_get_voltage(enum tegra_io_pad id) -{ - return -ENOSYS; -} ``` This function wasn't listed as a target of the series and isn't addressed in the cover letter. The implementation was already removed in a prior kernel version presumably, so this is just cleaning up a stale stub. Worth noting though since it could cause a build break for any out-of-tree code referencing it. --- Generated by Claude Code Patch Reviewer