From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/rockchip: dw_hdmi: Set output_port for RK3568/RK3566
Date: Sat, 16 May 2026 16:14:40 +1000 [thread overview]
Message-ID: <review-patch8-20260510183114.1248840-9-jonas@kwiboo.se> (raw)
In-Reply-To: <20260510183114.1248840-9-jonas@kwiboo.se>
Patch Review
**Status: Clean**
Adds `.output_port = 1` to `rk3568_hdmi_drv_data`. The commit message explains this is needed so the dw-hdmi bridge driver can find the display-connector bridge at port@1 once the dw-hdmi connector is replaced with a bridge connector.
The claim that all in-tree RK3568/RK3566 DTs with HDMI include the hdmi-connector node at port@1 is stated but not verified here -- this is a reasonable assertion given the author's domain expertise.
No issues.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 6:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 18:31 [PATCH 00/10] drm/rockchip: dw_hdmi: Misc cleanup and propagate bus format Jonas Karlman
2026-05-10 18:31 ` [PATCH 01/10] drm/rockchip: dw_hdmi: Use of_device_get_match_data() to get match data Jonas Karlman
2026-05-16 6:14 ` Claude review: " Claude Code Review Bot
2026-05-10 18:31 ` [PATCH 02/10] drm/rockchip: dw_hdmi: Use local dev variable consistently in bind() Jonas Karlman
2026-05-16 6:14 ` Claude review: " Claude Code Review Bot
2026-05-10 18:31 ` [PATCH 03/10] drm/rockchip: dw_hdmi: Use drmres helpers for encoder resources Jonas Karlman
2026-05-16 6:14 ` Claude review: " Claude Code Review Bot
2026-05-10 18:31 ` [PATCH 04/10] drm/rockchip: dw_hdmi: Inline resource lookup into bind() Jonas Karlman
2026-05-16 6:14 ` Claude review: " Claude Code Review Bot
2026-05-10 18:31 ` [PATCH 05/10] drm/rockchip: dw_hdmi: Hold a reference to the dw-hdmi bridge Jonas Karlman
2026-05-16 6:14 ` Claude review: " Claude Code Review Bot
2026-05-10 18:31 ` [PATCH 06/10] drm/rockchip: dw_hdmi: Remove empty encoder helper funcs Jonas Karlman
2026-05-16 6:14 ` Claude review: " Claude Code Review Bot
2026-05-10 18:31 ` [PATCH 07/10] drm/rockchip: dw_hdmi: Clean up whitespace Jonas Karlman
2026-05-16 6:14 ` Claude review: " Claude Code Review Bot
2026-05-10 18:31 ` [PATCH 08/10] drm/rockchip: dw_hdmi: Set output_port for RK3568/RK3566 Jonas Karlman
2026-05-16 6:14 ` Claude Code Review Bot [this message]
2026-05-10 18:31 ` [PATCH 09/10] drm/rockchip: dw_hdmi: Configure HDMI PHY in atomic_mode_set() Jonas Karlman
2026-05-16 6:14 ` Claude review: " Claude Code Review Bot
2026-05-10 18:31 ` [PATCH 10/10] drm/rockchip: dw_hdmi: Propagate bus format to display driver Jonas Karlman
2026-05-16 6:14 ` Claude review: " Claude Code Review Bot
2026-05-16 6:14 ` Claude review: drm/rockchip: dw_hdmi: Misc cleanup and propagate bus format Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch8-20260510183114.1248840-9-jonas@kwiboo.se \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox