From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/a6xx: Add yield & flush helper Date: Sat, 16 May 2026 15:20:23 +1000 Message-ID: In-Reply-To: <20260511130017.96867-9-robin.clark@oss.qualcomm.com> References: <20260511130017.96867-1-robin.clark@oss.qualcomm.com> <20260511130017.96867-9-robin.clark@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Good refactoring extracting `a6xx_flush_yield()`. One minor behavioral change: the preempt_start paths previously wrote `0x00` for the CP_CONTEXT_SWITCH_YIELD data value (dword[3]), while the submit path wrote `0x01`. The new shared helper uses `0x01` for both. Since the address (dwords 1-2) is zero, the data value is unused per the comment, so this is harmless. --- Generated by Claude Code Patch Reviewer