From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: analogix_dp: Rename and simplify is_rockchip() Date: Sat, 16 May 2026 12:26:18 +1000 Message-ID: In-Reply-To: <20260513074414.2053435-9-damon.ding@rock-chips.com> References: <20260513074414.2053435-1-damon.ding@rock-chips.com> <20260513074414.2053435-9-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Looks good** Pure cleanup: renames `is_rockchip()` to `analogix_dp_is_rockchip()` for proper namespace convention, and converts from chained `||` comparisons to a `switch` statement. All 9 call sites are updated consistently across `analogix_dp_core.c` and `analogix_dp_reg.c`. The switch-case approach is cleaner and avoids the need to extend a growing logical-or chain when new SoCs are added. --- Generated by Claude Code Patch Reviewer