From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/a6xx: Add yield & flush helper Date: Sat, 16 May 2026 10:50:09 +1000 Message-ID: In-Reply-To: <20260514134052.361771-9-robin.clark@oss.qualcomm.com> References: <20260514134052.361771-1-robin.clark@oss.qualcomm.com> <20260514134052.361771-9-robin.clark@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean refactor extracting the yield+flush pattern into `a6xx_flush_yield()`. One subtle change: the preempt_start path previously emitted `0x00` for the data value dword (not `0x01` as in the submit path), but now uses `0x01` via the shared helper. If this intentional difference mattered, it's now lost. However, since the address is 0 (skip write), the data value is unused, so this should be harmless. --- Generated by Claude Code Patch Reviewer