From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/syncobj: add drm_syncobj_query Date: Mon, 18 May 2026 16:53:31 +1000 Message-ID: In-Reply-To: <20260516-jorth-syncobj-v1-8-88ede9d98a81@gmail.com> References: <20260516-jorth-syncobj-v1-0-88ede9d98a81@gmail.com> <20260516-jorth-syncobj-v1-8-88ede9d98a81@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Same design concern as patch 7: ```c int drm_syncobj_query(struct drm_syncobj **syncobjs, u64 user_points, u32 count, u32 flags) ``` Again uses `u64_to_user_ptr(user_points)` internally for `copy_to_user()`. This is writing results back to userspace from inside an exported function, which is especially problematic -- a kernel-internal caller would need to fabricate a user pointer to receive results. This API should take `uint64_t *points` (a kernel buffer) and the ioctl wrapper should handle `copy_to_user`. Same applies to patch 7. --- Generated by Claude Code Patch Reviewer