From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: imx8mq: tqma8mq-mba8mx: Enable HDMI support Date: Mon, 25 May 2026 22:48:49 +1000 Message-ID: In-Reply-To: <20260519-dcss-hdmi-upstreaming-v23-8-5615524a9c63@oss.nxp.com> References: <20260519-dcss-hdmi-upstreaming-v23-0-5615524a9c63@oss.nxp.com> <20260519-dcss-hdmi-upstreaming-v23-8-5615524a9c63@oss.nxp.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Board-level enablement for TQ's MBA8MX carrier board. **Minor:** The `data-lanes = <0 1 2 3>;` is the identity mapping (no lane swapping). This is fine for HDMI where lane order typically matches. --- **Summary:** The series is in good shape for v23 and most critical issues from prior reviews have been addressed. The main remaining concerns are: (1) the `cdns_mhdp_base` pointer lifetime in the PHY driver with no protection against parent unbind, (2) the data duplication of `regs`/`sapb_regs`/`dev` between `cdns_mhdp_device` and its embedded `cdns_mhdp_base`, and (3) the HDCP receiver ID buffer overflow risk in the shared mailbox helper. None are blockers but should be addressed before merge. --- Generated by Claude Code Patch Reviewer