From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: sc8280xp-arcata: Add lid switch Date: Mon, 25 May 2026 21:20:10 +1000 Message-ID: In-Reply-To: <20260520-surface-sp9-5g-for-next-v1-8-9df52552bf87@gmail.com> References: <20260520-surface-sp9-5g-for-next-v1-0-9df52552bf87@gmail.com> <20260520-surface-sp9-5g-for-next-v1-8-9df52552bf87@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **No issues.** Adds a lid switch using GPIO 180 with proper `EV_SW`/`SW_LID` configuration and `EV_ACT_DEASSERTED` wakeup action. The `input.h` include is correctly added for the `SW_LID` and `EV_SW` defines. The pinctrl-0 list is correctly extended to include the new `hall_int_n_default`: ```diff - pinctrl-0 = <&vol_down_n>, <&vol_up_n>; + pinctrl-0 = <&hall_int_n_default>, <&vol_down_n>, <&vol_up_n>; ``` --- Generated by Claude Code Patch Reviewer