From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: params: Convert generic kernel_param_ops .get helpers to seq_buf Date: Mon, 25 May 2026 20:11:18 +1000 Message-ID: In-Reply-To: <20260521133326.2465264-8-kees@kernel.org> References: <20260521133315.work.845-kees@kernel.org> <20260521133326.2465264-8-kees@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This is the core conversion of all standard helpers (`param_get_bool`, `par= am_get_int`, etc.) and `param_array_get`. Also pulls in lockstep changes to= callers that delegate to these helpers (kfence, KVM, dmatest, apparmor). The `param_array_get` rework is well-done =E2=80=94 it now writes directly = into the parent `seq_buf` for `.get` ops, only falling back to the bounce b= uffer for legacy `.get_str` ops. One thing to note in the `param_array_get` conversion =E2=80=94 the replace= ment of the trailing newline with a comma is done by directly writing to `s= ->buffer[before - 1]`: ```c + if (i && s->buffer[before - 1] =3D=3D '\n') + s->buffer[before - 1] =3D ','; ``` This is reaching behind `seq_buf`'s back, but it's necessary for the comma-= separated output format and mirrors what the old code did with the raw buff= er. Acceptable. **Verdict: Correct conversions. The callers that delegate to standard helpe= rs are properly updated in lockstep.** --- Generated by Claude Code Patch Reviewer