From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/display: hdmi-state-helper: Act on color format DRM property Date: Mon, 25 May 2026 18:48:55 +1000 Message-ID: In-Reply-To: <20260522-color-format-v15-8-21fb136c9df2@collabora.com> References: <20260522-color-format-v15-0-21fb136c9df2@collabora.com> <20260522-color-format-v15-8-21fb136c9df2@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The switch in `hdmi_compute_config` has a subtle oddity: ```c if (conn_state->color_format != DRM_CONNECTOR_COLOR_FORMAT_AUTO) { switch (conn_state->color_format) { case DRM_CONNECTOR_COLOR_FORMAT_AUTO: drm_warn(connector->dev, "AUTO format in non-AUTO path.\n"); fallthrough; case DRM_CONNECTOR_COLOR_FORMAT_RGB444: fmt = DRM_OUTPUT_COLOR_FORMAT_RGB444; break; ``` The AUTO case inside the switch can never be reached because of the outer `if` guard. The `drm_warn` is dead code. If this is meant as defensive programming against future refactoring, a comment would help, but the warning will never fire as written. Consider removing the unreachable case or dropping the outer `if` and handling AUTO inside the switch directly. --- Generated by Claude Code Patch Reviewer