From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/a6xx: Add yield & flush helper Date: Mon, 25 May 2026 18:21:40 +1000 Message-ID: In-Reply-To: <20260522173349.55491-9-robin.clark@oss.qualcomm.com> References: <20260522173349.55491-1-robin.clark@oss.qualcomm.com> <20260522173349.55491-9-robin.clark@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean refactoring. The `a6xx_flush_yield` helper correctly replaces the duplicated yield+flush pattern in `a7xx_submit`, `a7xx_preempt_start`, and `a8xx_preempt_start`. Minor note: the preempt_start functions previously wrote `0x00` for dword[3] (the data value), while the submit path wrote `0x01`. The helper uses `0x01`. Looking at the original code: ```c // a7xx_submit (original): OUT_RING(ring, 0x01); // Data value // a7xx_preempt_start (original): OUT_RING(ring, 0x00); // Data value ``` The helper uses `0x01` for all cases. Since the address is 0x00 (meaning the write is skipped), the data value doesn't matter. So this is a benign behavioral no-op, but worth noting the change in the comment. --- Generated by Claude Code Patch Reviewer