From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/display: hdmi-state-helper: Act on color format DRM property Date: Mon, 25 May 2026 17:26:09 +1000 Message-ID: In-Reply-To: <20260523-color-format-v16-8-24340c5e4732@collabora.com> References: <20260523-color-format-v16-0-24340c5e4732@collabora.com> <20260523-color-format-v16-8-24340c5e4732@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The `DRM_CONNECTOR_COLOR_FORMAT_AUTO` case inside the `!=3D AUTO` branch wi= th `drm_warn` + `fallthrough` at line 678-681 is dead code by construction = (the outer `if` already checks `!=3D AUTO`). This is likely an artifact of = wanting to silence compiler warnings about unhandled enum values, and the `= drm_warn` does serve as a defensive canary. Acceptable. The AUTO behavior =E2=80=94 try RGB, fall back to YCbCr420 =E2=80=94 is cle= arly documented and matches the property documentation. No issues. --- Generated by Claude Code Patch Reviewer