From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: analogix_dp: Rename and simplify is_rockchip() Date: Tue, 26 May 2026 07:34:42 +1000 Message-ID: In-Reply-To: <20260525082033.117569-9-damon.ding@rock-chips.com> References: <20260525082033.117569-1-damon.ding@rock-chips.com> <20260525082033.117569-9-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Renames `is_rockchip()` to `analogix_dp_is_rockchip()` and converts to switch-case: ```c -static inline bool is_rockchip(enum analogix_dp_devtype type) +static inline bool analogix_dp_is_rockchip(enum analogix_dp_devtype type) { - return type == RK3288_DP || type == RK3399_EDP || type == RK3588_EDP; + switch (type) { + case RK3288_DP: + case RK3399_EDP: + case RK3588_EDP: + return true; + default: + return false; + } ``` Good cleanup. The namespace-prefixed name avoids potential conflicts. The switch-case makes adding new entries cleaner (as done in patch 9). All 9 call sites are updated. Note that `RK3576_EDP` is not yet added here -- that's done in patch 9, which is the correct ordering. --- Generated by Claude Code Patch Reviewer