From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: analogix_dp: Rename and simplify is_rockchip()
Date: Tue, 26 May 2026 07:12:13 +1000
Message-ID: <review-patch8-20260525125331.140059-9-damon.ding@rock-chips.com>
In-Reply-To: <20260525125331.140059-9-damon.ding@rock-chips.com>
References: <20260525125331.140059-1-damon.ding@rock-chips.com> <20260525125331.140059-9-damon.ding@rock-chips.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Clean refactor. The rename to `analogix_dp_is_rockchip()` follows namespace conventions, and the switch-case conversion is cleaner than chained `||`:

```c
+static inline bool analogix_dp_is_rockchip(enum analogix_dp_devtype type)
+{
+	switch (type) {
+	case RK3288_DP:
+	case RK3399_EDP:
+	case RK3588_EDP:
+		return true;
+	default:
+		return false;
+	}
 }
```

All 9 call sites in `analogix_dp_core.c` and `analogix_dp_reg.c` are updated. Correctly ordered before patch 9 which adds RK3576 to the switch.

No issues.

---
Generated by Claude Code Patch Reviewer